Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misleading comparison of GHActions w/ Jenkins #395

Closed
drewcoo opened this issue Oct 10, 2020 · 1 comment · Fixed by #493
Closed

misleading comparison of GHActions w/ Jenkins #395

drewcoo opened this issue Oct 10, 2020 · 1 comment · Fixed by #493
Assignees
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team triage Do not begin working on this issue until triaged by the team

Comments

@drewcoo
Copy link

drewcoo commented Oct 10, 2020

What is the current behavior?

This makes it seem like GHA supports matrices and Jenkins doesn't.

https://docs.github.com/en/free-pro-team@latest/actions/learn-github-actions/migrating-from-jenkins-to-github-actions#building-with-multiple-operating-systems

What changes are you suggesting?

Jenkins has supported matrix builds in pipelines for about a year now.
https://www.jenkins.io/blog/2019/11/22/welcome-to-the-matrix/

Please update the comparison doc.

Additional information

I think this is cannonical-ish Jenkins pipeline that also matches your code sample linked above. (The indentation was like that in your code sample.)

pipeline {
agent none
stages {
  stage('Run Tests') {
    matrix {
      axes {
        axis {
          name: 'PLATFORM'
          values: 'macos', 'linux'
        }
      }
      agent { label "${PLATFORM}" }
      stages {
        stage('test') {
          tools { nodejs "node-12" }
          steps {
            dir("scripts/myapp") {
              sh(script: "npm install -g bats")
              sh(script: "bats tests")
            }
          }
        }
      }
    }
  }
}
}
@drewcoo drewcoo added the engineering Will involve Docs Engineering label Oct 10, 2020
@welcome
Copy link

welcome bot commented Oct 10, 2020

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 10, 2020
@megbird megbird removed the engineering Will involve Docs Engineering label Oct 12, 2020
@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Oct 13, 2020
casals added a commit to casals/docs that referenced this issue Oct 13, 2020
@rachmari rachmari self-assigned this Nov 3, 2020
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this issue Oct 6, 2022
Co-authored-by: Jacob Prall <prall.jacob@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants