Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate that you may not be prompted to re-authenticate #33751

Merged
merged 4 commits into from
Jul 30, 2024
Merged

Indicate that you may not be prompted to re-authenticate #33751

merged 4 commits into from
Jul 30, 2024

Conversation

YanisaHS
Copy link
Contributor

Why:

This last step is a bit unclear what it means, and can be confusing if you aren't prompted to re-authenticate.

Closes:
Closes #33750

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@welcome Welcome
Copy link

welcome bot commented Jun 27, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 27, 2024 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
authentication/managing-commit-signature-verification/adding-a-gpg-key-to-your-github-account.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review authentication Content relating to authentication and removed triage Do not begin working on this issue until triaged by the team labels Jun 27, 2024
@nguyenalex836
Copy link
Contributor

@YanisaHS Thanks so much for opening a PR! I'll get this triaged for review ✨

Iamkeshy

This comment was marked as spam.

Sign in to view

@Howard13Kam

This comment was marked as spam.

Sign in to view
GJustin361

This comment was marked as spam.

Sign in to view

subatoi
subatoi reviewed Jul 30, 2024
View reviewed changes
Copy link
Contributor

@subatoi subatoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @YanisaHS and thanks for raising a PR 👋 — I've made one small suggestion. If you're happy with it, we can go ahead and get this merged

...entication/managing-commit-signature-verification/adding-a-gpg-key-to-your-github-account.md Outdated Show resolved Hide resolved
@github github deleted a comment from Sona2123 Jul 30, 2024
@YanisaHS @subatoi
Update adding-a-gpg-key-to-your-github-account.md
aed5ef9 
Co-authored-by: Ben Ahmady <32935794+subatoi@users.noreply.github.com>
@YanisaHS
Copy link
Contributor Author

Thanks @subatoi! Looks good to me 😄

subatoi
subatoi approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@subatoi subatoi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'll go ahead and merge this. Thanks again for your interest in the GitHub docs!

Edit: looks like we have some (likely transient) errors, so I'll look to merge this later today or tomorrow

@subatoi subatoi added this pull request to the merge queue Jul 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 30, 2024
@subatoi subatoi added this pull request to the merge queue Jul 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 30, 2024
@nguyenalex836 nguyenalex836 added this pull request to the merge queue Jul 30, 2024
Merged via the queue into github:main with commit 1ff7f7b Jul 30, 2024
43 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GJustin361 GJustin361 GJustin361 left review comments

@Iamkeshy Iamkeshy Iamkeshy left review comments

@subatoi subatoi subatoi approved these changes

Assignees
No one assigned
Labels
authentication Content relating to authentication content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub didn't prompt me to re-authenticate when adding a new GPG key
6 participants
@YanisaHS @nguyenalex836 @Howard13Kam @subatoi @GJustin361 @Iamkeshy