Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

developer route redirects load incorrectly on Windows #311

Closed
jeffmcaffer opened this issue Oct 9, 2020 · 0 comments
Closed

developer route redirects load incorrectly on Windows #311

jeffmcaffer opened this issue Oct 9, 2020 · 0 comments
Labels
bug An error or flaw that causes unintended or unexpected results engineering Will involve Docs Engineering

Comments

@jeffmcaffer
Copy link
Contributor

What is the current behavior?

On windows many of the content pages show up as having broken links in tests/links-and-images/links-and-images.js. for example,

     Found 116 total broken links: {
      "C:/git/docs/content/actions/guides/storing-workflow-data-as-artifacts.md": {
        "free-pro-team@latest": [
          {
            "broken link": "/en/free-pro-team@latest/v3/actions/artifacts",
            "reason": "linked page not found"
          }
        ],
        "enterprise-server@2.22": [
          {
            "broken link": "/en/enterprise-server@2.22/v3/actions/artifacts",
            "reason": "linked page not found"
          }
        ]
      },

What changes are you suggesting?

Turns out that the problem is actually in the parsing of redirects from the loaded pages. path.join is used at the end of the function to compute a key. since \ is used instead of /, the key is incorrect and the redirect does not get registered.

cc: @github/docs-engineering

@jeffmcaffer jeffmcaffer added bug An error or flaw that causes unintended or unexpected results engineering Will involve Docs Engineering labels Oct 9, 2020
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 9, 2020
@janiceilene janiceilene added windows and removed triage Do not begin working on this issue until triaged by the team labels Oct 9, 2020
@chiedo chiedo closed this as completed Oct 10, 2020
docs-bot added a commit that referenced this issue May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error or flaw that causes unintended or unexpected results engineering Will involve Docs Engineering
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants