Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions and clarifications around the CONTRIBUTING file #1981

Closed
ScriptAutomate opened this issue Dec 10, 2020 · 9 comments · Fixed by #6110
Closed

Suggestions and clarifications around the CONTRIBUTING file #1981

ScriptAutomate opened this issue Dec 10, 2020 · 9 comments · Fixed by #6110
Labels
content This issue or pull request belongs to the Docs Content team good first issue Good for newcomers help wanted Anyone is welcome to open a pull request to fix this issue

Comments

@ScriptAutomate
Copy link

ScriptAutomate commented Dec 10, 2020

What article on docs.github.com is affected?

What part(s) of the article would you like to see updated?

A new section: How GitHub uses the CONTRIBUTING file

  • It appears as checked on the Community page
  • It appears as the designated CONTRIBUTING.* guide on the repo contribute page

Then there is this section:

Decide whether to store your contributing guidelines in your repository's root, docs, or .github directory. Then, in the filename field, type the name and extension for the file. Contributing guidelines filenames are not case sensitive, and can have an extension such as .md or .txt.

The such as piece throws me off. Does it mean any extension (such as .rst, often found in Python projects), or is there a limited like to the extensions accepted for the contributing file, or? This should be reworded for clarification. I have noticed that .rst does get picked up, so I know it is at least included.

The other problem with that section:

  • For the contribute page, what CONTRIBUTING.* file path takes most importance? As in, what if a muddled project has the following:
    • .github/CONTRIBUTING.md
    • docs/CONTRIBUTING.md
    • CONTRIBUTING.md

What's the order of importance?


Maintainer note:

Please follow the Content design plan below to resolve this issue 🎉

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 10, 2020
@janiceilene
Copy link
Contributor

Thanks so much for opening an issue! I'll get this triaged for the right team to take a look ⚡

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core and removed triage Do not begin working on this issue until triaged by the team labels Dec 10, 2020
@felicitymay
Copy link
Contributor

Hi @ScriptAutomate thanks for raising this issue. It's an interesting area and you're right to highlight the ambiguities in the information we currently have. I'll see if I can find the missing information, then we can create content design with your suggestions above and the additional information.

@felicitymay felicitymay self-assigned this Jan 15, 2021
@felicitymay
Copy link
Contributor

Once the content design is complete, the issue will be ready for a help wanted label.

@felicitymay
Copy link
Contributor

felicitymay commented Jan 15, 2021

Notes

It might also be worth mentioning in About default labels that adding a good first issue label to an issue adds it to the contribute page.

Contributing file precedence:

  • .github is preferred over root-level and docs
  • root-level is preferred over docs

All file extensions are supported. If there is a rich-text view available for the contributing file this is used, otherwise the raw text is displayed. For more information, see "Rendering differences in prose documents."

@felicitymay
Copy link
Contributor

Content design plan

Proposed content design plan to address this issue.

Topics to update:

  • Setting guidelines for repository contributors
    • At the start of the topic, add a new H3 title: "About contributing guidelines"
    • Expand the first paragraph to explain that:
    • Revise step 3 of the Adding a CONTRIBUTING file procedure to explain that the file will be rendered using a rich text format if it's in a supported format and add the link: For more information, see "[Rendering differences in prose documents](https://docs.github.com/en/github/managing-files-in-a-repository/rendering-differences-in-prose-documents)."
    • At the end of the Adding a CONTRIBUTING file procedure, add a short sentence that explains that if a repository contains more than one CONTRIBUTING file, then the file shown in links is chosen from .github, the top-level directory, then the docs directory.
  • Managing labels topic, section About default labels

@janiceilene janiceilene added good first issue Good for newcomers help wanted Anyone is welcome to open a pull request to fix this issue labels Jan 20, 2021
@janiceilene
Copy link
Contributor

Anyone is welcome to pick this up, following @felicitymay's Content design plan above ☝️

@felicitymay felicitymay removed their assignment Jan 22, 2021
@Devilishhh
Copy link

I would like to attempt this if possible @janiceilene

@janiceilene
Copy link
Contributor

@Devilishhh You're welcome to open a PR!

@Devilishhh
Copy link

@janiceilene brilliant thank you kindly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team good first issue Good for newcomers help wanted Anyone is welcome to open a pull request to fix this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants