-
Notifications
You must be signed in to change notification settings - Fork 60.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflow_call's github context event_name ambiguity #16515
Comments
Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
@Skenvy |
This is a gentle bump for the docs team that this issue is waiting for technical review. |
This comment was marked as spam.
This comment was marked as spam.
@Skenvy Thanks so much for your patience. I spoke with the team and we are not going to accept this contribution 💛. We really appreciate your time and interest in improving GitHub docs 💖 . |
In other parts of the docs, the |
I had exactly the same confusion and this issue appears to be the only documentation on this issue. Please reconsider clarifying what context values are in the case of |
While the trigger is listed as `workflow_call`, apparently the inherited event retains the original `workflow_dispatch` name. See github/docs#16515
I found this issue and a discussion at actions/runner#1884 I have a workflow When I followed the "solution" in the linked discussion. name: create-test-db
on:
workflow_call:
+ inputs:
+ is_workflow_call:
+ description: 'Ugh'
+ required: true
+ type: string
+ default: 'true'
workflow_dispatch:
jobs: |
Code of Conduct
What article on docs.github.com is affected?
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_call
What part(s) of the article would you like to see updated?
The paragraph for the "workflow_call" event is somewhat ambiguous with the mixing terms of "webhook payload" and "event payload", and says;
But there is a distinction in naming between the "webhook" payload and the "event" payload across the rest of the docs. When reading this description, it implies that there would be a webhook payload associed with the workflow_call event, perhaps one mentioned on https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads (although there is none) that would simply have the same
github.event
payload as calling workflow, but that the other generic "webhook" payload fields would be equivalent to others.For example, I assumed upon reading it that the
github.event_name
field, being not in thegithub.event
payload, would equalworkflow_call
, and was surprised to discover that the event name was also the same as that of the "webhook payload" that initiated the callee workflow.This description could be made more clear by saying that it adopts the "webhook" payload of the callee, rather than just the "event" payload.
Additional information
No response
The text was updated successfully, but these errors were encountered: