Favicon might be invisible

[SharakPL]

What is the current behavior?

What changes are you suggesting?

Make favicon black and white across all GitHub services available from the browser. Otherwise it can be invisible when browser uses dark mode or a theme with dark colors.

Edit: Even though dark mode does update favicon in tabs it still doesn't change favicon in bookmarks so it really needs 2 colors:

[welcome]

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

[b4mboo]

I checked the favicon's behavior in dark mode in Safari and Chrome on macOS Catalina:

Can we close this issue?

[b4mboo]

@SharakPL Thanks again for opening this issue. ✨
While we won't be able to address all possible color schemes, I wonder whether you're able to produce a situation where enabling dark mode would render the favicon invisible? If so, please feel free to reopen this issue with more details.

It's worth mentioning that this repository only serves https://docs.github.com, so other GitHub-owned services or pages are out of scope.

[SharakPL]

@b4mboo maybe it works for Chrome/Edge and Safari because it relies on browser's dark mode feature, but Firefox doesn't seem to have that. Dark mode is enabled simply by activating dark theme and it looks even worse there:

Adding a background-color to svg icon or <circle ... fill="#fff"> element would fix the problem.

Just look how Google did it ;)

---

Actually Firefox does have dark mode feature in default theme, but it relies on OS' dark mode (Windows in my case) so only if I enable dark mode for apps in Windows settings Github favicon changes to white. I am using this theme, but I don't want dark mode for apps. So maybe it's dark mode checking script that needs fixing to consider windows specific settings...

[b4mboo]

Your observation is correct. GitHub relies on the browser to communicate the dark mode flag. Changing this behavior, however, is beyond the scope of this open source repository, which only holds the content for GitHub's documentation.

[SharakPL]

@b4mboo I was aware it's not specific to @github Docs but couldn't find any better place as it does impact all sites the same way. Could you direct me to repository that can handle this issue?

[b4mboo]

@SharakPL The best way to request new features or enhancements like this one would be through GitHub's Support: https://support.github.com/contact

[SharakPL]

Thanks 😊