Skip to content
This repository has been archived by the owner on Sep 22, 2022. It is now read-only.

Opt out (or in?) to close button? #10

Closed
shawnbot opened this issue Apr 4, 2018 · 0 comments · Fixed by #11
Closed

Opt out (or in?) to close button? #10

shawnbot opened this issue Apr 4, 2018 · 0 comments · Fixed by #11

Comments

@shawnbot
Copy link
Contributor

shawnbot commented Apr 4, 2018

First of all, this is rad! I'm experimenting with it in Primer land, though, and the .dd-close-button that it adds automatically is giving me grief. Could we make it possible to opt out of that button if we're providing one with the data-close-dialog attribute, or maybe just check to see if that selector is found before creating it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant