Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm deps #64

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Update npm deps #64

merged 4 commits into from
Jan 18, 2024

Conversation

smorimoto
Copy link
Contributor

@smorimoto smorimoto commented Jan 17, 2024

Correct unused or unlisted dependencies.

Although it was not intended, this reduces the size of the package 🤷‍♂️

Before

CJS dist/index.cjs     7.53 KB
ESM dist/index.js     6.82 KB

After

CJS dist/index.cjs     4.94 KB
ESM dist/index.js     4.21 KB

Signed-off-by: Sora Morimoto <sora@morimoto.io>
@smorimoto smorimoto requested a review from a team as a code owner January 17, 2024 20:29
Signed-off-by: Sora Morimoto <sora@morimoto.io>
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
example/package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
@smorimoto
Copy link
Contributor Author

You can confirm this with Knip:

npx knip

knip.json

{
  "$schema": "https://unpkg.com/knip/schema.json",
  "workspaces": {
    ".": {
      "entry": ["src/index.ts", "src/*.test.ts"],
      "project": "src/*.ts"
    },
    "example": {
      "entry": ["index.ts", "*.test.ts"],
      "project": "*.ts"
    }
  }
}

package.json Show resolved Hide resolved
Copy link

@febuiles febuiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question, but looks good to me!

package.json Show resolved Hide resolved
@febuiles febuiles merged commit ce17ae9 into github:main Jan 18, 2024
3 checks passed
@smorimoto smorimoto deleted the update-npm-deps branch January 18, 2024 15:34
@smorimoto
Copy link
Contributor Author

This change is not included in the latest point release, but are you planning to release this?

@febuiles
Copy link

@smorimoto it will go out with the next release release.

@smorimoto
Copy link
Contributor Author

@febuiles Could you publish a new point release for this?

@febuiles
Copy link

@smorimoto If I push the PR I'll need to get someone's approval, can you update the version and push a PR? I can then be the approver and do the release.

@smorimoto
Copy link
Contributor Author

@febuiles Sure!

@smorimoto smorimoto mentioned this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants