Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue if repo contributors are empty #43

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Continue if repo contributors are empty #43

merged 2 commits into from
Oct 27, 2023

Conversation

zkoppert
Copy link
Member

@zkoppert zkoppert commented Oct 25, 2023

Fixes #42

Proposed Changes

  • Continue if a repo's contributors are empty instead of panic

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, or breaking

Signed-off-by: Zack Koppert <zkoppert@github.com>
@zkoppert
Copy link
Member Author

@mister-ben Hopefully this works for what you are thinking.

@zkoppert zkoppert self-assigned this Oct 25, 2023
@zkoppert zkoppert added the bug Something isn't working label Oct 25, 2023
@mister-ben
Copy link

Thanks, that works. Although I think the message to delete the repo and try again if you need the repo is at best confusing, and potentially dangerously misleading in case it's ever triggered by an unforeseen reason other than being an empty repo.

@zkoppert
Copy link
Member Author

@mister-ben I updated to just remove that confusing line. I'm thinking that the notification that we couldn't get collaborators from the repo and the status code should be helpful without being misleading.

@zkoppert zkoppert merged commit 997b977 into main Oct 27, 2023
6 checks passed
@zkoppert zkoppert deleted the empty-repos branch October 27, 2023 20:56
@zkoppert
Copy link
Member Author

Creating a release to get this out there. Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organization stats fail if any repo is empty
2 participants