SSA: Update data flow integration and BarrierGuard interface to use GuardValue. #20132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschackmull
added
the
no-change-note-required
github-actions
bot
added
C#
JS
C++
Java
Ruby
Rust
There was a problem hiding this comment.
Pull Request Overview
This PR updates the SSA data flow integration interface to use a generic GuardValue type instead of boolean for guard expressions. This change refactors the internal API to support wrapper types for barrier guards while maintaining the same external behavior.
- Introduces a
GuardValueclass as an abstract value type for guard evaluations - Updates all guard-related predicates to use
GuardValueinstead ofboolean - Replaces method names to include "Value" prefix (e.g.,
hasBranchEdge→hasValueBranchEdge)
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| shared/ssa/codeql/ssa/Ssa.qll | Defines the new GuardValue class and updates all guard interface predicates |
| shared/dataflow/codeql/dataflow/VariableCapture.qll | Implements GuardValue as Void type for variable capture scenarios |
| rust/ql/lib/codeql/rust/dataflow/internal/SsaImpl.qll | Updates Rust implementation to use Boolean as GuardValue type |
| ruby/ql/lib/codeql/ruby/dataflow/internal/SsaImpl.qll | Updates Ruby implementation to use Boolean as GuardValue type |
| javascript/ql/lib/semmle/javascript/dataflow/internal/sharedlib/Ssa.qll | Updates JavaScript SSA implementation with Boolean guard values |
| javascript/ql/lib/semmle/javascript/dataflow/internal/TaintTrackingPrivate.qll | Updates taint tracking to use Boolean type for guard checks |
| javascript/ql/lib/semmle/javascript/dataflow/internal/BarrierGuards.qll | Updates barrier guards implementation with Boolean type |
| java/ql/lib/semmle/code/java/dataflow/internal/SsaImpl.qll | Updates Java implementation to use Guards::GuardValue type |
| csharp/ql/lib/semmle/code/csharp/dataflow/internal/SsaImpl.qll | Updates C# implementation to use Boolean as GuardValue type |
| cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaInternals.qll | Updates C++ SSA internals to use Boolean guard values |
| cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll | Updates C++ iterator flow to use Void as GuardValue type |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
geoffw0
reviewed
Jul 28, 2025
|
Dca looks uneventful for all languages - except a weird OOM in sarif export for JS. But I would think that's unlikely to be related to this PR. |
|
Looks like the JS dca problem is unrelated - the same thing happened on #19854, which was approved and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just tweaks the internal api in SSA to support BarrierGuard wrappers from #20121. Semantics and external interfaces remain unchanged.