Swift: skip declarations marked as unavailable #14437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffw0
reviewed
Oct 11, 2023
DCA is in progress. dbscheme change is in the other PR which is not strictly related to these changes. |
redsun82
approved these changes
Oct 11, 2023
Comment on lines
+282
to
+287
| for (auto member : decl.getMembers()) { | ||
| if (swift::AvailableAttr::isUnavailable(member)) { | ||
| continue; | ||
| } | ||
| entry.members.emplace_back(dispatcher.fetchLabel(member)); | ||
| } |
There was a problem hiding this comment.
I was about to suggest using C++20's views like this
Suggested change
| for (auto member : decl.getMembers()) { | |
| if (swift::AvailableAttr::isUnavailable(member)) { | |
| continue; | |
| } | |
| entry.members.emplace_back(dispatcher.fetchLabel(member)); | |
| } | |
| entry.members = | |
| dispatcher.fetchRepeatedLabels(decl.getAllMembers() | |
| | std::views::filter(std::not_fn(swift::AvailableAttr::isUnavailable))); |
until I tried it out and stumbled upon llvm/llvm-project#52696
The code above requires at least clang-16 to compile 😭
I guess this might be an input to the self contained toolchain, that we should upgrade clang in the process (including on Linux)
geoffw0
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically, this is a no-op for our test suite, though I'm not sure why the order has changed.
This is required for #14261 as it fixes a crash when we try to extract certain unavailable declarations.