Bump @octokit/plugin-throttling from 8.1.3 to 9.0.3 #1001
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [@octokit/plugin-throttling](https://github.com/octokit/plugin-throttling.js) from 8.1.3 to 9.0.3. - [Release notes](https://github.com/octokit/plugin-throttling.js/releases) - [Commits](octokit/plugin-throttling.js@v8.1.3...v9.0.3) --- updated-dependencies: - dependency-name: "@octokit/plugin-throttling" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
|
I've combined this with #997 because it seems they need to be done together in order for the code to compile. Both of these modules have changed to ESM packages. Thankfully, unlike the vscode-codeql repo, it seems we can make this upgrade and we aren't stuck waiting for any further packages to release their updated version. |
|
It seems it's no longer auto-detecting the correct types. Possibly it's an inconsistency with the For now we can get things working by adding in explicit types. These are the types that were determined automatically before, and looking at https://github.com/octokit/plugin-throttling.js/blob/v9.0.3/src/types.ts#L5 they are still the correct types. Adding in those types didn't change the generated javascript at all. |
|
I think it would be better to wait until all modules have been updated to ESM since we are now including two different versions of certain modules (e.g. |
|
Thanks for spotting that. Other than clearing the dependabot backlog there's no reason to rush these updates. We can leave this until all of the relevant packages have updated to ESM. |
|
A newer version of @octokit/plugin-throttling exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
bot
deleted the
dependabot/npm_and_yarn/octokit/plugin-throttling-9.0.3
branch
Bumps @octokit/plugin-throttling from 8.1.3 to 9.0.3.
Release notes
Sourced from
@octokit/plugin-throttling's releases.Commits
f151af4fix(pkg): addmainfield (#678)0551690fix(README): update examples for ESM (#679)dbc2d38build(deps): lock file maintenance (#680)1c64559fix: add missing file extension on bottleneck import (#676)4986fb0feat: package is now ESM (#675)0404bc6feat: new endpoints (#674)5f90bc4build(deps): lock file maintenance (#673)a770925chore: fix spelling errors (#672)8a8eac6build(deps): lock file maintenance06a3935build(deps): lock file maintenance (#669)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)