Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract git-utils.ts #2639

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Extract git-utils.ts #2639

merged 3 commits into from
Dec 10, 2024

Conversation

cklin
Copy link
Contributor

@cklin cklin commented Dec 9, 2024

This is a refactoring PR that addresses the TODO item left from #2559.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@cklin cklin marked this pull request as ready for review December 9, 2024 23:03
@cklin cklin requested a review from a team as a code owner December 9, 2024 23:03
henrymercer
henrymercer previously approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Are there any other changes beyond reorganizing the files? I didn't see anything obvious, but wanted to double check.

Base automatically changed from cklin/diff-informed-graph-fetching-tweak to main December 10, 2024 16:42
@cklin cklin dismissed henrymercer’s stale review December 10, 2024 16:42

The base branch was changed.

@cklin
Copy link
Contributor Author

cklin commented Dec 10, 2024

Thanks for this! Are there any other changes beyond reorganizing the files? I didn't see anything obvious, but wanted to double check.

This is a pure refactoring PR, and there are no changes beyond reorganizing the files.

@cklin cklin force-pushed the cklin/extract-git-utils branch from 9bdb53b to 300d251 Compare December 10, 2024 16:46
@cklin cklin requested a review from henrymercer December 10, 2024 16:46
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 10, 2024
View reviewed changes
src/git-utils.ts Dismissed Show dismissed Hide dismissed
@cklin cklin merged commit 4d64ab6 into main Dec 10, 2024
265 checks passed
@cklin cklin deleted the cklin/extract-git-utils branch December 10, 2024 18:26
This was referenced Dec 12, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrymercer henrymercer henrymercer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cklin @henrymercer