Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permissions to pr-checks workflow #2555

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Oct 20, 2024

Without this, I get: https://github.com/check-spelling-sandbox/github-codeql-action/actions/runs/11429827970/job/31796641932

Run github/codeql-action/upload-sarif@v3
Warning: Resource not accessible by integration
Uploading results
  Processing sarif files: ["eslint.sarif"]
  Validating eslint.sarif
  Combining SARIF files using the CodeQL CLI
  Adding fingerprints to SARIF file. See https://docs.github.com/en/enterprise-cloud@latest/code-security/code-scanning/integrating-with-code-scanning/sarif-support-for-code-scanning#providing-data-to-track-code-scanning-alerts-across-runs for more information.
  Uploading results
  Warning: Resource not accessible by integration
  Error: Resource not accessible by integration
  Warning: Resource not accessible by integration

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@jsoref jsoref requested a review from a team as a code owner October 20, 2024 22:14
Copy link
Member

@NlightNFotis NlightNFotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would like someone else to have a look at this before we merge this.

Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the fix!

@henrymercer henrymercer merged commit 165a22e into github:main Oct 21, 2024
269 checks passed
@jsoref jsoref deleted the fix-pr-check-permissions branch October 21, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants