Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always upload eslint.sarif #2474

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Always upload eslint.sarif #2474

merged 1 commit into from
Sep 12, 2024

Conversation

aeisenberg
Copy link
Contributor

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 10, 2024
View reviewed changes
src/status-report.ts Fixed Show fixed Hide fixed
src/status-report.ts Fixed Show fixed Hide fixed
src/status-report.ts Fixed Show fixed Hide fixed
src/status-report.ts Fixed Show fixed Hide fixed
@aeisenberg aeisenberg force-pushed the aeisenberg/always-upload-eslint-sarif branch from 908133d to 0d0f998 Compare September 10, 2024 23:09
@aeisenberg aeisenberg marked this pull request as ready for review September 10, 2024 23:10
@aeisenberg aeisenberg requested a review from a team as a code owner September 10, 2024 23:10
@aeisenberg
Copy link
Contributor Author

@rvermeulen, can I get another review?

angelapwen
angelapwen approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means that it will always upload even if previous steps fail, right? 👍

@aeisenberg aeisenberg merged commit 4a01ec7 into main Sep 12, 2024
616 checks passed
@aeisenberg aeisenberg deleted the aeisenberg/always-upload-eslint-sarif branch September 12, 2024 17:18
@aeisenberg
Copy link
Contributor Author

aeisenberg commented Sep 12, 2024 •
edited
Loading

This means that it will always upload even if previous steps fail, right? 👍

Yes.

Here's an example of this working: #2473

Oh...I see now that the only alerts left are ones where autofix didn't generate a fix. But please trust me that it worked.

@github-actions github-actions bot mentioned this pull request Sep 13, 2024
Merged
8 tasks
@dbartol dbartol mentioned this pull request Sep 13, 2024
Merged
8 tasks
@angelapwen angelapwen mentioned this pull request Sep 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelapwen angelapwen angelapwen approved these changes

@rvermeulen rvermeulen Awaiting requested review from rvermeulen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeisenberg @angelapwen