-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support security-experimental
as a well-known suite
#1519
Support security-experimental
as a well-known suite
#1519
Conversation
5039ea0
to
5e71946
Compare
5e71946
to
8c8bc11
Compare
Skipped/failing test is unrelated (observed on other SHAs as well) so marking ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Another thing to consider is adding the security-experimental
suite to .github/codeql/codeql-config.yml
. This would give us a little more assurance that this suite will continue working.
Have added the suite into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, though I realise now that we run the CodeQL check using both the latest and the cached tools, so we'll probably have to wait until 2.12.2 is released before we can update .github/codeql/codeql-config.yml
.
Ah yeah that makes sense. I've made the changes and will make a note for the two follow-up changes (adding the suite to |
This change adds
security-experimental
as a well-known query suite that can be specified under thequeries
input. Note that this change is intended for internal/field users and will not be publicized in our changelog or documentation.The suite will be supported for CLI versions 2.11.1+, and an error will be thrown if the suite was specified but the CLI version is not up to date.
As
security-experimental
includes the ML-powered queries, we test via the existing ML-powered query tests.Merge / deployment checklist