Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable file baseline information behind a feature gate #1329

Merged
merged 4 commits into from
Nov 7, 2022
Merged

Enable file baseline information behind a feature gate #1329

merged 4 commits into from
Nov 7, 2022

Conversation

henrymercer
Copy link
Contributor

@henrymercer henrymercer commented Oct 27, 2022 •
edited
Loading

  • Add feature
  • Use feature to selectively enable --sarif-add-baseline-file-info
  • Wait until we have a 2.11.3 nightly so we can test the PR check we'll implement next.
  • Add PR check that enables the feature using an environment variable

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer force-pushed the henrymercer/file-baseline-info-enablement branch from 893e54a to cf9de76 Compare November 1, 2022 17:00
@henrymercer henrymercer force-pushed the henrymercer/file-baseline-info-enablement branch from cf9de76 to 89e1893 Compare November 1, 2022 17:11
@henrymercer henrymercer marked this pull request as ready for review November 7, 2022 16:41
@henrymercer henrymercer requested a review from a team as a code owner November 7, 2022 16:41
aeisenberg
aeisenberg approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@henrymercer henrymercer merged commit c606252 into main Nov 7, 2022
@henrymercer henrymercer deleted the henrymercer/file-baseline-info-enablement branch November 7, 2022 18:10
This was referenced Nov 14, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrymercer @aeisenberg