Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct program name #1268

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Correct program name #1268

merged 1 commit into from
Sep 28, 2022

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Sep 25, 2022

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@jsoref jsoref requested a review from a team as a code owner September 25, 2022 03:27
yoff
yoff previously approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@yoff yoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

henrymercer
henrymercer reviewed Sep 26, 2022
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jsoref, thank you for your contribution! Just one more step before we can merge this — please could you follow the steps in https://github.com/github/codeql-action/blob/main/CONTRIBUTING.md#development-and-testing to build the Action? This should update the lib/actions-util.js and lib/actions-util.js.map files. Once you've checked these in, the PR checks should go green.

@jsoref jsoref dismissed stale reviews from edoardopirovano and yoff via a4e4529 September 28, 2022 02:08
edoardopirovano
edoardopirovano approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@edoardopirovano edoardopirovano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you!

@edoardopirovano edoardopirovano merged commit 28c63d1 into github:main Sep 28, 2022
@jsoref jsoref deleted the rev-parse branch September 28, 2022 11:47
This was referenced Sep 29, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrymercer henrymercer henrymercer left review comments

@edoardopirovano edoardopirovano edoardopirovano approved these changes

@yoff yoff yoff left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsoref @yoff @edoardopirovano @henrymercer