Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-XMLHttpRequest doesn't work in AMD (and breaks Webpack, and possibly Browserify) #259

Closed
aendra-rininsland opened this issue Nov 18, 2015 · 4 comments

Comments

@aendra-rininsland
Copy link
Member

Currently AMD tries to load node-xmlhttprequest as a dependency, and given that library doesn't have a UMD, everything breaks. This is particularly problematic with Webpack, because it tries to load the AMD version and fails upon first XHR use.

Will be resolved via #252.

Thanks to @patrykkopycinski for the report!

@pizn
Copy link

pizn commented Jan 10, 2016

I have encountered this problem. What time released v0.10.8?

@ldd
Copy link

ldd commented Jan 14, 2016

I made a really ugly fix to use this with webpack: https://gist.github.com/ldd/c1a20595765fab416ebe

I hope v0.10.8 fixes everything :)

@AurelioDeRosa
Copy link
Member

This will be fixed in version 0.10.8. A preview can be seen here.

@AurelioDeRosa
Copy link
Member

Issue fixed and it'll be available when we release the new version.

dmison added a commit to dmison/Serum that referenced this issue Nov 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants