Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html_url and url are both pointing to 'https://api.github.com..' #140

Closed
phun-ky opened this issue Mar 1, 2018 · 2 comments · Fixed by #142
Closed

html_url and url are both pointing to 'https://api.github.com..' #140

phun-ky opened this issue Mar 1, 2018 · 2 comments · Fixed by #142

Comments

@phun-ky
Copy link

phun-ky commented Mar 1, 2018

Using:

gren changelog --include-messages=all -B --override

gren -V
0.15.0

With this template:

{
  "dataSource": "commits",
  "prefix": "",
  "includeMessages": "all",
  "changelogFilename": "CHANGELOG.md",
  "template": {
    "commit": "- [{{message}}]({{html_url}}) - {{author}}",
    "issue": "- {{labels}} {{name}} [{{text}}]({{html_url}})",
    "label": "[**{{label}}**]",
    "noLabel": "closed",
    "group": "\n#### {{heading}}\n",
    "changelogTitle": "# Changelog\n\n",
    "release": "## {{release}} ({{date}})\n{{body}}",
    "releaseSeparator": "\n---\n\n"
  }
}

The {{html_url}} or {{url}} is returning https://api.github.com/repo, and not the HTML URL which seems to be intended

@phun-ky phun-ky changed the title html_url and url are both pointing to ''* html_url and url are both pointing to 'https://api.github.com..' Mar 1, 2018
phun-ky pushed a commit to phun-ky/github-release-notes that referenced this issue Mar 1, 2018
@phun-ky
Copy link
Author

phun-ky commented Mar 1, 2018

nice @alexcanessa ! will test this directly, and see if it works! Could you build a prerelease with this option?

@alexcanessa
Copy link
Member

@phun-ky just checkout master and run npm i -g . to use gren from your local folder and test 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants