-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
D.R.Y up Vim modeline expression #5365
Conversation
I think we also need to add |
Derp. 🤦🤦 You're right. At least one of us is paying attention. 😅 |
@lildude We've hit a snag:
This is failing because a VimBall file (see #4412) ends with a help file modeline: As the name suggests, VimBalls are the Vim equivalent of a tarball: a concatenation of several files with headers betwixt each blob of data: I'm not sure what to do here. |
Oh (vim)balls!!!
Yeah, I'm not too sure either. That change is needed in order to fix #5347 (cos of the size of the file) but doing so breaks VimBall detection. I'll need to have a think about it. |
Got it!! Vimballs are really easy to find thanks to the first few lines always containing We can use this to our advantage in the modeline strategy with no extra cost. I'll push my changes to this branch. |
Description
Fixes:#5347 by updating the Vim Help heuristic with fixes made in #5271 (which should've included
heuristics.yml
as well… 🤦). I've added a reminder tomodeline.rb
so something like this doesn't happen again.(Template removed as it doesn't apply)