add .template as an extension for JSON files (for AWS CloudFormation)

[eliah-hecht-zocdoc]

AWS CloudFormation uses JSON files ending in .template.

Here's a search: https://github.com/search?utf8=%E2%9C%93&q=extension%3Atemplate+AWSTemplateFormatVersion&type=Code&ref=searchresults

[arfon]

Thanks for this @eliah-hecht-zocdoc. Please accept the CLA and we can merge this contribution.

[eliah-hecht-zocdoc]

Will do as soon as I can, waiting on my legal team to approve.

[pchaigno]

It looks like there are many .template files which are not AWS CloudFormation files or even JSON files (352,000 vs. the 4,500 which are JSON) :/

[arfon]

It looks like there are many .template files which are not AWS CloudFormation files or even JSON files (352,000 vs. the 4,500 which are JSON) :/

D'oh, yeah. Thanks for checking that @pchaigno. @eliah-hecht-zocdoc we need to work out what the other files are before we can consider merging this sorry as in its current form, this Pull Request would mark every .template file on GitHub as JSON

[eliah-hecht-zocdoc]

Seems like the other .template files are all over the map. Is it worth trying to figure it out, or should we just abandon this?

[arfon]

Seems like the other .template files are all over the map. Is it worth trying to figure it out, or should we just abandon this?

@eliah-hecht-zocdoc - I agree. This is likely quite a lot of work. If you're up for it then we (regular committers/maintainers) can probably review stuff for you but a successful contribution here is probably going to rely upon your personal enthusiasm for this 😄

[eliah-hecht-zocdoc]

Gotcha, I think I will let it drop for now. Thanks :)

[PatMyron]

some CloudFormation template recognition discussions if anyone's looking to pick this back up again:

aws-cloudformation/cfn-lint#1171, aws-cloudformation/cfn-lint-visual-studio-code#99, aws/aws-toolkit-jetbrains#1715 (comment), https://github.com/github/super-linter/pull/231#discussion_r445708695, mwpearce/vscode-cfn-nag#6, joenye/coc-cfn-lint#3 (comment), aws-cloudformation/cfn-lint-atom#29