justfile: Truncate container tag string if too long #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems (from CI failures and local tests) that container's tags can't be longer than 128 characters. Sometimes CI generates tag that are longer than this (thanks Dependabot for the extra-long branch names). Make sure we don't break docker builds by having bash truncate the string if necessary. Fixes: b88ec42 ("Build system") Signed-off-by: Quentin Monnet <qmo@qmon.net>
daniel-noland
force-pushed
the
pr/qmonnet/branch-truncate
branch
from
edc9f82 to
2cf87d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems (from CI failures and local tests) that container's tags can't be longer than 128 characters. Sometimes CI generates tag that are longer than this (thanks Dependabot for the extra-long branch names).
Make sure we don't break docker builds by having bash truncate the string if necessary.
Fixes: #21