Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md: Add RUSTC var to vscode setup #217

Merged
merged 1 commit into from
Feb 7, 2025
Merged

README.md: Add RUSTC var to vscode setup #217

merged 1 commit into from
Feb 7, 2025

Conversation

mvachhar
Copy link
Contributor

@mvachhar mvachhar commented Feb 7, 2025

Apparently, RUSTC is needed as well so that rust-analyzer doesn't use the system one instead of the sysroot one.

@mvachhar mvachhar requested a review from a team as a code owner February 7, 2025 00:44
@mvachhar mvachhar requested review from Fredi-raspall and removed request for a team February 7, 2025 00:44
qmonnet
qmonnet approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thank you, can you please sign-off your commit?

@qmonnet qmonnet added the dont-merge Do not merge this Pull Request label Feb 7, 2025
@mvachhar
README.md: Add RUSTC var to vscode setup
409c693 
Signed-off-by: Manish Vachharajani <manish@githedgehog.com>
@mvachhar mvachhar force-pushed the pr/manish/vscode-setup branch from d3eadca to 409c693 Compare February 7, 2025 20:05
@mvachhar
Copy link
Contributor Author

mvachhar commented Feb 7, 2025

Looks good thank you, can you please sign-off your commit?

Done.

@mvachhar mvachhar removed the dont-merge Do not merge this Pull Request label Feb 7, 2025
@mvachhar mvachhar enabled auto-merge February 7, 2025 20:16
@mvachhar mvachhar added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit 5444939 Feb 7, 2025
12 of 13 checks passed
@mvachhar mvachhar deleted the pr/manish/vscode-setup branch February 7, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

@Fredi-raspall Fredi-raspall Awaiting requested review from Fredi-raspall Fredi-raspall is a code owner automatically assigned from githedgehog/dataplane-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvachhar @qmonnet