More consistent error codes and format #114
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These 3 commits attempt to make the API more consistent in returning JSON errors with non-2xx HTTP error codes.
Starting with Express 5, route handlers and middleware that return a Promise will call next(value) automatically when they reject or throw an error
. If this repo is ever ever upgraded to Express 5 (currently on 4.17) or later these new try blocks can be entirely removed, the next() calls will be automatic.The 4th commit updates a code comment to reflect the latest code.