Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: series header description field #5041

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

feat: series header description field #5041

wants to merge 6 commits into from
+263 −107

Conversation

ndom91
Copy link
Contributor

@ndom91 ndom91 commented Oct 4, 2024 •
edited
Loading

☕️ Reasoning

  • Allow both adding and removing "description" field to series via kebab menu "Add/Remove description" option on Series header (StackingBranchHeader.svelte)
  • Extract InputLabel.svelte into own component and allow two variants - input and textarea for single and multi-line versions

🧢 Changes

  • Extracted existing BranchLabel.svelte combination label/input field into InputLabel.svelte which then is used by BranchLabel/StackingBranchDescription(new)

@ndom91
feat: extract text input / label component and make textarea/input va…
5179d96 
…riants

fix: autoSelectBranchName feature flag behaviour
@vercel Vercel
Copy link

vercel bot commented Oct 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
gitbutler-web ⬜️ Skipped (Inspect) Oct 7, 2024 4:32pm

@ndom91 ndom91 force-pushed the ndom91/series-description-field branch from e33218b to 56fbc3f Compare October 4, 2024 13:55
@ndom91 ndom91 force-pushed the ndom91/series-description-field branch from bbf2c87 to 5fa4c83 Compare October 4, 2024 14:44
@ndom91 ndom91 force-pushed the ndom91/series-description-field branch from 5fa4c83 to fdb7dc2 Compare October 4, 2024 14:53
@ndom91 ndom91 force-pushed the ndom91/series-description-field branch from de012e2 to c410b58 Compare October 4, 2024 15:51
@ndom91 ndom91 marked this pull request as ready for review October 4, 2024 15:53
@ndom91 ndom91 force-pushed the ndom91/series-description-field branch from 2b8a826 to 8f6eded Compare October 4, 2024 16:08
@ndom91 ndom91 force-pushed the ndom91/series-description-field branch from 8f6eded to b1b672b Compare October 4, 2024 16:08
@ndom91 ndom91 force-pushed the ndom91/series-description-field branch from b1b672b to db474eb Compare October 4, 2024 16:09
@ndom91 ndom91 force-pushed the ndom91/series-description-field branch from 445d842 to ea78f31 Compare October 7, 2024 13:56
@github-actions github-actions bot added the rust Pull requests that update Rust code label Oct 7, 2024
@ndom91 ndom91 marked this pull request as draft October 7, 2024 15:10
@ndom91
fix: abstract textarea/input html element into own component
c17dd2c 
Merge branch 'master' into ndom91/series-description-field
Merge branch 'master' into ndom91/series-description-field
fix: prettier
@ndom91 ndom91 force-pushed the ndom91/series-description-field branch from fd17e56 to c17dd2c Compare October 7, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtsgrd mtsgrd Awaiting requested review from mtsgrd

@Caleb-T-Owens Caleb-T-Owens Awaiting requested review from Caleb-T-Owens

@estib-vega estib-vega Awaiting requested review from estib-vega

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
@gitbutler/desktop @gitbutler/ui rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndom91 @Caleb-T-Owens