Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate Icon.svelte to svelte 5 syntax #4990

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ndom91
Copy link
Contributor

@ndom91 ndom91 commented Sep 29, 2024

☕️ Reasoning

  • Follow up svelte-5 migration (see: feat: svelte 5 migration #4989) for the @gitbutler/ui package contents
  • Seems only the Icon.svelte component wasn't already in Svelte 5/runes syntax

🧢 Changes

  • Migrate Icon.svelte to Svelte 5 runes syntax

Copy link

vercel bot commented Sep 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2024 5:11pm

Copy link
Contributor

@PavelLaptev PavelLaptev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :-)

Copy link
Contributor

@Caleb-T-Owens Caleb-T-Owens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants