Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update nix config #4915

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: update nix config #4915

wants to merge 1 commit into from

Conversation

gkze
Copy link

@gkze gkze commented Sep 16, 2024

☕️ Reasoning

The Tauri-recommended Flake uses flake-utils, which has outgrown its original purpose a bit and handles outputs less cleanly than flake-parts. I realize that there's the nascent Flakelight out there but for now my sense is that flake-parts the optimal option.

Also add numtide/devshell, which handles native C/C++ library dependencies a bit more elegantly.

🧢 Changes

  • Swap out flake-utils for flake parts
  • Add numtide/devshell
  • Add .envrc to help with Nix-related changes a bit

Was able to build (not AppImage but doesn't build on master anyways - separate issue) and run the dev build on my primary daily driver NixOS system.

Would be interesting to see why it's not producing the AppImage on master on NixOS, just haven't dedicated enough time.

Copy link

vercel bot commented Sep 16, 2024

@gkze is attempting to deploy a commit to the GitButler Team on Vercel.

A member of the Team first needs to authorize it.

The Tauri-recommended Flake uses flake-utils, which has outgrown its
original purpose a bit and handles outputs less cleanly than
[flake-parts](https://flake.parts/). I realize that there's the nascent
[Flakelight](https://github.com/nix-community/flakelight) out there but
for now my sense is that flake-parts is the optimal option.

Also add [numtide/devshell](https://github.com/numtide/devshell),
which handles native C/C++ library dependencies a bit more elegantly.
@ndom91
Copy link
Contributor

ndom91 commented Sep 16, 2024

Thanks for your interest! So this new devshell setup mostly works on my system.

The dev instance of GitButler does start up, but I immediately have console errors about TLS/SSL support no available, install glib-networking. So let's put glib-networking back into the nativeLibs deps?

Also I was also never able to build the AppImage on my NixOS system either, the provided build_appimage.sh script always failed, I don't remember the exact details atm though.

@ndom91
Copy link
Contributor

ndom91 commented Sep 16, 2024

Also, the font rendering seems a bit off, see this comparison screenshot. Before is in the background and after (with your devShell) is in the foreground outlined in red:

image

Seems that we really might need to include pango/cairo as runtime dependencies?

@Byron Byron added the feedback requested Feedback was requested to help resolve the issue label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback requested Feedback was requested to help resolve the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants