Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

Type definitions for sprestlib #24

Closed
Jandos22 opened this issue May 30, 2018 · 4 comments
Closed

Type definitions for sprestlib #24

Jandos22 opened this issue May 30, 2018 · 4 comments
Assignees
Milestone

Comments

@Jandos22
Copy link
Contributor

Hi, @gitbrent

Do you plan to add type definitions for your library?

screenshot_01

image

@gitbrent
Copy link
Owner

gitbrent commented Jun 8, 2018

Update: Created new branch for type defs work: type-defs-issue24

@gitbrent gitbrent self-assigned this Jun 8, 2018
@gitbrent
Copy link
Owner

Hi @Wireliner ,

My initial pass at a definitions file is now available on the dev branch. It worked for me using Atom and the Typescript plugin.

Let me what you think.

sprestlib.d.ts

@Jandos22
Copy link
Contributor Author

Hi @gitbrent ,

Great enhancement to SpRestLib! I tested them just now with VS Code.

I also made a pull request as I think all list and rest methods should return Promise, user method options input should (?) be optional. You may update other places where Promise is needed.

I also get an error:

image

It only works after adding "new" in front. Honestly, I am still a beginner in programming, so not sure what exactly is the case of an issue.

Regards,
Zhandos

gitbrent pushed a commit that referenced this issue Jun 23, 2018
@gitbrent gitbrent added this to the 1.8.0 milestone Jun 23, 2018
gitbrent pushed a commit that referenced this issue Jun 23, 2018
@gitbrent
Copy link
Owner

gitbrent commented Jul 8, 2018

I've updated the typedefs and verified user is setup like the other classes, so hopefully that issue is resolved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants