read-cache: run verify_hdr() in background thread #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a performance optimization. Teach do_read_index() to call verify_hdr() using a thread and allow SHA1 verification to run concurrently with the parsing of index-entries and extensions. For large index files, this cuts the startup time in half. Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
|
Very nice! I think I will refactor this a little bit when sending it upstream, so that we end up with a single |
dscho
added a commit
to git-for-windows/build-extra
that referenced
this pull request
Dec 2, 2016
Reading a large index [has been speeded up using pthreads](git-for-windows/git#978). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
That's fine. I was mainly concentrating on the timings for (very) large repos. I also expect a discussion on the threshold value for enabling it. On a 16Mb index file, it saved about 0.03 seconds. On a 450Mb index file it saved 0.7 seconds -- which gives us 10-20% on short-running commands. |
|
And thanks for the quick review! |
dscho
added a commit
that referenced
this pull request
Dec 6, 2016
…y_hdr read-cache: run verify_hdr() in background thread
dscho
added a commit
that referenced
this pull request
Dec 12, 2016
…y_hdr read-cache: run verify_hdr() in background thread
dscho
added a commit
that referenced
this pull request
Jan 11, 2017
…y_hdr read-cache: run verify_hdr() in background thread
dscho
added a commit
that referenced
this pull request
Jan 18, 2017
…y_hdr read-cache: run verify_hdr() in background thread
dscho
added a commit
that referenced
this pull request
Jan 18, 2017
…y_hdr read-cache: run verify_hdr() in background thread
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 18, 2017
…y_hdr read-cache: run verify_hdr() in background thread
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 18, 2017
…y_hdr read-cache: run verify_hdr() in background thread
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 18, 2017
…y_hdr read-cache: run verify_hdr() in background thread
dscho
added a commit
that referenced
this pull request
Jan 24, 2017
…y_hdr read-cache: run verify_hdr() in background thread
dscho
added a commit
that referenced
this pull request
Jan 24, 2017
…y_hdr read-cache: run verify_hdr() in background thread
dscho
added a commit
that referenced
this pull request
Jan 24, 2017
…y_hdr read-cache: run verify_hdr() in background thread
dscho
added a commit
that referenced
this pull request
Jan 25, 2017
…y_hdr read-cache: run verify_hdr() in background thread
dscho
added a commit
that referenced
this pull request
Jan 25, 2017
…y_hdr read-cache: run verify_hdr() in background thread
dscho
added a commit
that referenced
this pull request
Jan 25, 2017
…y_hdr read-cache: run verify_hdr() in background thread
dscho
added a commit
that referenced
this pull request
Jan 25, 2017
…y_hdr read-cache: run verify_hdr() in background thread
dscho
added a commit
to dscho/git
that referenced
this pull request
Feb 1, 2017
…er/thread_verify_hdr read-cache: run verify_hdr() in background thread
dscho
added a commit
that referenced
this pull request
Feb 2, 2017
…y_hdr read-cache: run verify_hdr() in background thread
git-for-windows-ci
pushed a commit
that referenced
this pull request
Feb 2, 2017
…y_hdr read-cache: run verify_hdr() in background thread
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 20, 2017
…y_hdr read-cache: run verify_hdr() in background thread
dscho
added a commit
that referenced
this pull request
Sep 20, 2017
…y_hdr read-cache: run verify_hdr() in background thread
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 21, 2017
…y_hdr read-cache: run verify_hdr() in background thread
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 21, 2017
…y_hdr read-cache: run verify_hdr() in background thread
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 26, 2017
…y_hdr read-cache: run verify_hdr() in background thread
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 26, 2017
…y_hdr read-cache: run verify_hdr() in background thread
dscho
added a commit
that referenced
this pull request
Sep 26, 2017
…y_hdr read-cache: run verify_hdr() in background thread
dscho
added a commit
that referenced
this pull request
Oct 17, 2017
…y_hdr read-cache: run verify_hdr() in background thread
dscho
added a commit
that referenced
this pull request
Oct 19, 2017
…y_hdr read-cache: run verify_hdr() in background thread
dscho
added a commit
that referenced
this pull request
Oct 19, 2017
…y_hdr read-cache: run verify_hdr() in background thread
dscho
added a commit
that referenced
this pull request
Oct 19, 2017
…y_hdr read-cache: run verify_hdr() in background thread
dscho
added a commit
that referenced
this pull request
Oct 19, 2017
…y_hdr read-cache: run verify_hdr() in background thread
dscho
added a commit
that referenced
this pull request
Oct 19, 2017
…y_hdr read-cache: run verify_hdr() in background thread
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 20, 2017
…y_hdr read-cache: run verify_hdr() in background thread
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 20, 2017
…y_hdr read-cache: run verify_hdr() in background thread
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 20, 2017
…y_hdr read-cache: run verify_hdr() in background thread
dscho
added a commit
that referenced
this pull request
Oct 20, 2017
…y_hdr read-cache: run verify_hdr() in background thread
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 21, 2017
…y_hdr read-cache: run verify_hdr() in background thread
dscho
added a commit
that referenced
this pull request
Oct 23, 2017
…y_hdr read-cache: run verify_hdr() in background thread
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 24, 2017
…y_hdr read-cache: run verify_hdr() in background thread
dscho
added a commit
that referenced
this pull request
Oct 30, 2017
…y_hdr read-cache: run verify_hdr() in background thread
dscho
added a commit
that referenced
this pull request
Nov 1, 2017
…y_hdr read-cache: run verify_hdr() in background thread
dscho
added a commit
that referenced
this pull request
Nov 6, 2017
…y_hdr read-cache: run verify_hdr() in background thread
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 7, 2017
…y_hdr read-cache: run verify_hdr() in background thread
dscho
added a commit
that referenced
this pull request
Nov 29, 2017
…y_hdr read-cache: run verify_hdr() in background thread
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 6, 2017
…y_hdr read-cache: run verify_hdr() in background thread
dscho
added a commit
that referenced
this pull request
Jan 2, 2018
…y_hdr read-cache: run verify_hdr() in background thread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a performance optimization.
Teach do_read_index() to call verify_hdr() using a thread
and allow SHA1 verification to run concurrently with the
parsing of index-entries and extensions.
For large index files, this cuts the startup time in half.
Signed-off-by: Jeff Hostetler jeffhost@microsoft.com