git bundle create <bundle> leaks handle the revlist is empty.
#797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue #790: git bundle create does not close handle to *.lock file This problem happens when an user tries to create an empty bundle, using the following command: `git bundle create <bundle> <revlist>` and when <revlist> resolve to an empty list (for example, like `master..master`), `git bundle` fails and warn the user about how it don't want to create empty bundle. In that case, git tries to delete the `<bundle>.lock` file, and since there's still an open file handle, fails to do so and ask the user if it should retry (which will fail again). The lock can still be deleted manually by the user (and it is required if the user want to create a bundle after revising his rev-list). Signed-off-by: Gaël Lhez <gael.lhez@gmail.com>
|
Perfect, thanks! |
dscho
added a commit
to git-for-windows/build-extra
that referenced
this pull request
Jun 23, 2016
When `git bundle create` is asked to create an empty bundle, it is supposed to error out and delete the corrupt bundle file. The deletion [no longer fails due to an unreleased lock file](git-for-windows/git#797). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
that referenced
this pull request
Jul 12, 2016
`git bundle create <bundle>` leaks handle the revlist is empty.
dscho
added a commit
that referenced
this pull request
Jul 16, 2016
`git bundle create <bundle>` leaks handle the revlist is empty.
dscho
added a commit
that referenced
this pull request
Jul 23, 2016
`git bundle create <bundle>` leaks handle the revlist is empty.
dscho
added a commit
that referenced
this pull request
Jul 23, 2016
`git bundle create <bundle>` leaks handle the revlist is empty.
dscho
added a commit
that referenced
this pull request
Jul 23, 2016
`git bundle create <bundle>` leaks handle the revlist is empty.
dscho
added a commit
that referenced
this pull request
Jul 27, 2016
`git bundle create <bundle>` leaks handle the revlist is empty.
dscho
added a commit
that referenced
this pull request
Jul 27, 2016
`git bundle create <bundle>` leaks handle the revlist is empty.
dscho
added a commit
that referenced
this pull request
Jul 29, 2016
`git bundle create <bundle>` leaks handle the revlist is empty.
dscho
added a commit
that referenced
this pull request
Aug 2, 2016
`git bundle create <bundle>` leaks handle the revlist is empty.
dscho
added a commit
that referenced
this pull request
Aug 2, 2016
`git bundle create <bundle>` leaks handle the revlist is empty.
dscho
pushed a commit
that referenced
this pull request
Aug 2, 2016
`git bundle create <bundle>` leaks handle the revlist is empty.
dscho
pushed a commit
that referenced
this pull request
Aug 2, 2016
`git bundle create <bundle>` leaks handle the revlist is empty.
dscho
pushed a commit
that referenced
this pull request
Aug 5, 2016
`git bundle create <bundle>` leaks handle the revlist is empty.
dscho
pushed a commit
that referenced
this pull request
Aug 6, 2016
`git bundle create <bundle>` leaks handle the revlist is empty.
dscho
added a commit
that referenced
this pull request
May 29, 2018
`git bundle create <bundle>` leaks handle the revlist is empty.
dscho
added a commit
that referenced
this pull request
May 29, 2018
`git bundle create <bundle>` leaks handle the revlist is empty.
PKRoma
pushed a commit
to PKRoma/git-for-windows
that referenced
this pull request
Jun 22, 2018
`git bundle create <bundle>` leaks handle the revlist is empty.
PKRoma
pushed a commit
to PKRoma/git-for-windows
that referenced
this pull request
Jun 22, 2018
`git bundle create <bundle>` leaks handle the revlist is empty.
PKRoma
pushed a commit
to PKRoma/git-for-windows
that referenced
this pull request
Jun 22, 2018
`git bundle create <bundle>` leaks handle the revlist is empty.
dscho
added a commit
that referenced
this pull request
Aug 22, 2018
`git bundle create <bundle>` leaks handle the revlist is empty.
dscho
added a commit
to dscho/git
that referenced
this pull request
Aug 22, 2018
`git bundle create <bundle>` leaks handle the revlist is empty.
dscho
added a commit
that referenced
this pull request
Aug 23, 2018
`git bundle create <bundle>` leaks handle the revlist is empty.
dscho
added a commit
that referenced
this pull request
Aug 23, 2018
`git bundle create <bundle>` leaks handle the revlist is empty.
dscho
added a commit
that referenced
this pull request
Aug 23, 2018
`git bundle create <bundle>` leaks handle the revlist is empty.
jamill
pushed a commit
to jamill/git
that referenced
this pull request
Aug 28, 2018
`git bundle create <bundle>` leaks handle the revlist is empty.
jamill
pushed a commit
to jamill/git
that referenced
this pull request
Sep 5, 2018
`git bundle create <bundle>` leaks handle the revlist is empty.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 10, 2018
`git bundle create <bundle>` leaks handle the revlist is empty.
jamill
pushed a commit
to jamill/git
that referenced
this pull request
Sep 11, 2018
`git bundle create <bundle>` leaks handle the revlist is empty.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 24, 2018
`git bundle create <bundle>` leaks handle the revlist is empty.
dscho
added a commit
that referenced
this pull request
Oct 10, 2018
`git bundle create <bundle>` leaks handle the revlist is empty.
dscho
added a commit
to dscho/git
that referenced
this pull request
Oct 11, 2018
This was pull request git-for-windows#797 from glhez/master `git bundle create <bundle>` leaks handle the revlist is empty. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
to dscho/git
that referenced
this pull request
Nov 19, 2018
This was pull request git-for-windows#797 from glhez/master `git bundle create <bundle>` leaks handle the revlist is empty. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
that referenced
this pull request
Nov 21, 2018
This was pull request #797 from glhez/master `git bundle create <bundle>` leaks handle the revlist is empty. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #790: git bundle create does not close handle to *.lock file
This problem happens when an user tries to create an empty bundle, using the
following command:
git bundle create <bundle> <revlist>and whenresolve to an empty list (for example, like
master..master),git bundlefailsand warn the user about how it don't want to create empty bundle.
In that case, git tries to delete the
<bundle>.lockfile, and since there's stillan open file handle, fails to do so and ask the user if it should retry (which will
fail again).
The lock can still be deleted manually by the user (and it is required if the user
want to create a bundle after revising his rev-list).
Signed-off-by: Gaël Lhez gael.lhez@gmail.com