Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-artifacts: Update ARM64 GCM Core workaround #3085

Merged
merged 1 commit into from
Mar 10, 2021
Merged

git-artifacts: Update ARM64 GCM Core workaround #3085

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/git-artifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,8 +425,8 @@ jobs:
if: matrix.arch.arm64 == true
shell: bash
run: |
printf '%s\n' '#!/bin/sh' 'exec /mingw32/libexec/git-core/git-credential-manager-core.exe "$@"' > arm64/bin/git-credential-manager-core
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bet it works if it's put into arm64/libexec/git-core/ instead of arm64/bin/.

And honestly, I'd prefer that over the build-extra PR, to minimize the impact outside git-artifacts...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dscho that works, thanks! Just updated the commit accordingly.

I was curious as to what libexec does exactly, and found this definition:

libexec is meant for system daemons and system utilities executed by other programs. That is, the binaries put in this namespaced directory are meant for the consumption of other programs, and are not intended to be executed directly by users.

Learning every day 🚀

chmod +x arm64/bin/git-credential-manager-core
printf '%s\n' '#!/bin/sh' 'exec /mingw32/libexec/git-core/git-credential-manager-core.exe "$@"' > arm64/libexec/git-core/git-credential-manager-core
chmod +x arm64/libexec/git-core/git-credential-manager-core
- name: Clone and update build-extra
if: env.SKIP != 'true'
shell: bash
Expand Down