Assorted fixes/enhancements for the git-artifacts workflow
#3053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscho
force-pushed
the
assorted-git-artifacts-fixes
branch
2 times, most recently
from
37e0f7e to
bfb078c
Compare
|
Oh, sorry @dennisameling, I forgot to cc: you here... This should be interesting. FWIW I saw something rather concerning: the ARM64 artifacts are super large! Likewise, nothing about I did start to investigate how to port 179227d to |
@dennisameling to see what I mean, please compare the artifact sizes of https://github.com/dscho/git/actions/runs/596316620 (whose mingit-arm64 weighs 205MB!) to https://github.com/dscho/git/actions/runs/597692856 (mingit-arm64 weighs only 38.6MB, which however is still a lot larger than mingit-i686 that weighs 22.2MB). |
Isn't a size increase in roughly that ballpark region to be expected due to the current nature of our arm releases? Or do we already exclude the x86 versions of the executables we compile natively? |
It's slightly larger than necessary because we don't exclude ARM64 files from MinGit as we do with i686 files. At least that's what I think is the issue.
No, we specifically ship all of he i686 binaries in the ARM64 flavor. |
1 task
Yes, I mentioned that in #3017 (comment), but didn't know how to fix it back then. Definitely needed someone who's more familiar with the Git for Windows codebase. So, thank you for looking into this! Highly appreciated 😊 This seems to work correctly, but I'm currently stuck on #3071 (comment) so can't really test this further. I did see some |
This is needed to allow for the artifact checksum to be computed. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Let's use a more verbose, slightly more readable conditional. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Let's skip this step if it isn't needed. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
... just removing two superfluous empty lines... Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Let's adjust the indentation to conform with the coding style of the remainder of the file. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Since the directory can contain spaces, we need to quote it, but we cannot do that directly (but have to store the option in a variable), therefore we need to `eval` the command-line. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
GitHub workflows run in agents that have quite a bit of stuff in their `PATH`, e.g. Chocolatey. To make sure that those bits and pieces are _not_ used to build the artifacts, let's whittle down the `PATH` to contain the bare minimum. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
The workflow allows users to restrict what parts are being built. For example, `installer-i686` will build only the 32-bit installer, not the 64-bit one nor any MinGit flavor. However, this logic was not extended when introducing support for ARM64: Instead, we _also_ built the ARM64 installer when the user asked for `installer-i686`. Let's allow restricting to `installer-i686` _without_ building the ARM64 version, and allow restricting to `installer-arm64` _just_ for the ARM64 version. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
When the user asked for `installer-x86_64`, there is no point in building `pkg-i686` or `build-arm64`; Let's be a bit smarter about this. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This workflow needs to be triggered manually, and it offers to specify a couple input parameters. But none of them are required. Make that explicit. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
…vision We cannot just check out the current revision: The user might have overridden `REPOSITORY` and `REF` via the workflow dispatch. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This simplifies the workflow dramatically. Note that we have to reinstate that `/usr/bin/git` hack (a shell script that simply redirects to `/mingw64/bin/git.exe`) in the `pkg` job manually, since we no longer cache the `build-installers` artifact _after_ installing that hack in `bundle-artifacts`. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
assorted-git-artifacts-fixes
branch
from
bfb078c to
2b11260
Compare
dscho
added a commit
to dscho/git
that referenced
this pull request
Mar 5, 2021
This corresponds to git-for-windows#3053. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
to dscho/git
that referenced
this pull request
Mar 5, 2021
This corresponds to git-for-windows#3053. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
that referenced
this pull request
Mar 6, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
dscho
added a commit
that referenced
this pull request
Mar 6, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
dscho
added a commit
that referenced
this pull request
Mar 6, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 2, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
dscho
added a commit
to dscho/git
that referenced
this pull request
Aug 3, 2021
…acts-fixes Assorted fixes/enhancements for the `git-artifacts` workflow
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 3, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
dscho
added a commit
that referenced
this pull request
Aug 3, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
dscho
added a commit
that referenced
this pull request
Aug 3, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
dscho
added a commit
that referenced
this pull request
Aug 3, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 4, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 4, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
dscho
added a commit
that referenced
this pull request
Aug 4, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
dscho
added a commit
that referenced
this pull request
Aug 4, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 4, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 4, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
dscho
added a commit
that referenced
this pull request
Aug 6, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 6, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 6, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
dscho
added a commit
that referenced
this pull request
Aug 11, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
dscho
added a commit
that referenced
this pull request
Aug 13, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
dscho
added a commit
that referenced
this pull request
Aug 18, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
dscho
added a commit
that referenced
this pull request
Aug 23, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 24, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
dscho
added a commit
that referenced
this pull request
Aug 31, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 8, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
dscho
added a commit
that referenced
this pull request
Sep 13, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
dscho
added a commit
that referenced
this pull request
Oct 4, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 12, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 12, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
dscho
added a commit
that referenced
this pull request
Oct 13, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 13, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 13, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 13, 2021
Assorted fixes/enhancements for the `git-artifacts` workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
git-artifactsworkflow can be used to generate Git for Windows installers, MinGits, etc.The improvements in this PR mostly revolve around two topics: actually make the ARM64 stuff work (it didn't work when I tried it), and accelerate the entire thing, mostly by using the shiny new
setup-git-for-windows-sdkGitHub Action.