git-artifacts(ARM64): add git-credential-manager-core-wrapper #331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In git-for-windows/git#3076, we added a workaround for GCM Core by adding a wrapper in
arm64/bin/git-credential-manager-core
. What I didn't realize back then was that I had a hard link to GCM Core in my~/.gitconfig
, so everything seemed to work as expected.However, I just tried a clean installation of Git for Windows on ARM64 and removed my
~/.gitconfig
. Then ran into:... even though
arm64/bin/git-credential-manager-core
was present. When I moved the file tomingw32/bin/git-credential-manager-core
, everything started to work as expected:This PR adds
git-credential-manager-core
to the proper folder inmingw32
. Additional benefit is that folks will have this fix included, even when their artifacts weren't built with GitHub Actions:https://github.com/dennisameling/git/blob/6686bba2f0a38f78f8406116c5adc8e7dcd0fd82/.github/workflows/git-artifacts.yml#L421-L427
I'll remove the workaround in
git-artifacts.yml
as this PR is a successor to it.