Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-artifacts(ARM64): add git-credential-manager-core-wrapper #331

Conversation

dennisameling
Copy link
Contributor

@dennisameling dennisameling commented Mar 7, 2021

In git-for-windows/git#3076, we added a workaround for GCM Core by adding a wrapper in arm64/bin/git-credential-manager-core. What I didn't realize back then was that I had a hard link to GCM Core in my ~/.gitconfig, so everything seemed to work as expected.

However, I just tried a clean installation of Git for Windows on ARM64 and removed my ~/.gitconfig. Then ran into:

PS C:\repos\demo-repo> git push
git: 'credential-manager-core' is not a git command. See 'git --help'.
Username for 'https://github.com':

... even though arm64/bin/git-credential-manager-core was present. When I moved the file to mingw32/bin/git-credential-manager-core, everything started to work as expected:

PS C:\repos\demo-repo> git push
Everything up-to-date

This PR adds git-credential-manager-core to the proper folder in mingw32. Additional benefit is that folks will have this fix included, even when their artifacts weren't built with GitHub Actions:

https://github.com/dennisameling/git/blob/6686bba2f0a38f78f8406116c5adc8e7dcd0fd82/.github/workflows/git-artifacts.yml#L421-L427

I'll remove the workaround in git-artifacts.yml as this PR is a successor to it.

Since there is no GCM Core for ARM64, let's just install a simple shell script that calls the i686 version for now.

Signed-off-by: Dennis Ameling <dennis@dennisameling.com>
dennisameling added a commit to dennisameling/git that referenced this pull request Mar 7, 2021
We have moved and improved this logic to `build-extra` in git-for-windows/build-extra#331

Signed-off-by: Dennis Ameling <dennis@dennisameling.com>
@dennisameling
Copy link
Contributor Author

Closing in favor of git-for-windows/git#3085

@dennisameling dennisameling deleted the git-credential-manager-core-arm64 branch March 8, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant