Skip to content

Improve auto-detection to avoid long web request timeouts #384

@mjcheetham

Description

@mjcheetham

As mentioned in #364, during the host provider auto-detection when GCM makes a HTTP call to the remote, this can sometimes hang until a long timeout period has elapsed (1 minute?).

We should improve the "2nd level" auto-detection in a few ways:

  1. Add fast-path identification of other host providers from the remote URL hostname
  2. Add more heuristics for common on-prem remote URLs like we do for github.<domain>.<tld> => GHES/AE
  3. Set a short timeout for the HTTP request
  4. Parallelise the HTTP request with other "1st level" detection
  5. Cache the results of the identification request(?)
    a. Prompt the user to remember (set credential.provider) the detected provider(?)

Metadata

Metadata

Assignees

Labels

auth-issueAn issue authenticating to a hostenhancementNew feature or requestperformanceAn issue with performance

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions