Create large images for all items in a folder #1568
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manthey
reviewed
Jul 9, 2024
| @@ -17,6 +19,7 @@ def addSystemEndpoints(apiRoot): | |||
| """ | |||
| apiRoot.folder.route('GET', (':id', 'yaml_config', ':name'), getYAMLConfigFile) | |||
| apiRoot.folder.route('PUT', (':id', 'yaml_config', ':name'), putYAMLConfigFile) | |||
| apiRoot.folder.route('PUT', (':id', 'items'), createLargeImages) | |||
There was a problem hiding this comment.
This adds the endpoint folder/:id/items. Other endpoints that are explicitly for large_images are either in item/:id/tiles/... or large_image/.... I think, conceptually, this is a utility function so it would make more sense to move this to rest/large_image_resource.py endpoint and rename the route to ('folder', ':id', 'create') (though I could also see using tiles rather than create for consistency).
There was a problem hiding this comment.
That route and location make more sense. Function moved and route renamed here.
When bioformats tries to open a zip file, it opens the file once per internal file. If it fails to find a file that can be opened within the zip, it throws an error and leaves all of the file handles open. By dividing the reader into more steps, we can ask to open an empty file, which somehow releases the file handles.
Fix DOI badge rendering on GitHub
The client test to use different viewers is failing because of some external package change. Disable it for now.
There isn't anything actionable until zarr 3 and zarr-sqlitestore are released.
This allows better control over how files with styled sources are rendered.
gabrielle6249
force-pushed
the
folder-recheck
branch
from
614a53b to
456829e
Compare
…sh commits from master # dependency-type: direct:production #update-type: version-update:semver-major
gabrielle6249
force-pushed
the
folder-recheck
branch
from
37a57ac to
955f5bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an endpoint that creates large images for an entire folder, as mentioned here. It iterates through the folder's items and creates a large image item for each if it isn't one already, with the option to recurse child folders. It also has an option to create a job for each large image item, and another to make the jobs local.
This does not yet finish creating large images for items with a large image in progress, but seemed to be a good start.