-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Max Merge option in Frame Selector #1306
Conversation
5d997df
to
0ed1c44
Compare
0ed1c44
to
1abc9ce
Compare
This looks like the right approach. In band compositing mode on the normmedia_8well_col2_livecellgfp.nd2 test file, I see nulls being send for the framedelta. And, one further wrinkle: we really should be showing the histogram of the max-merged image, not the un-merged image. This means that we need to pass the appropriate style to the histogram endpoint when max-merge is checked. |
This is working, though there is an eccentricity in non-8-bit images. Specifically, when a style gets applied, the histogram ends up in 8 bits, which then breaks the sliders setting correct values for the min / max (the auto range works fine). I added a PR (#1326) that allows adding Not necessarily for this PR: Minor styling desires: Can we make "Max Merge" fit on the same line to reduce vertical height slightly? The label Otherwise, the only issue I see is one of performance -- we ask for the histograms faster than we can handle them resulting in having stale requests when scrubbing quickly. Can we debounce that in any way? |
Addresses #1118