Updating mimetype accept header parsing to use builtin aspnet parse/methods #516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 485
This change updates the
mustAccept
to base it's decisions on the values of parsed MediaTypeHeaderValue values instead of strings.It utilizes the isSubsetOf method of that class in order to do proper subset matching.
While the parsing is wrapped in an exception handler during the runtime execution, the construction of the function does not wrap the parsing. This is so that it will fail fast on startup (developer supplied values), but tolerate malformed values at runtime (bad user input).
I've added only a couple of tests, but believe it should suffice for this scenario since the code leans on the Net builtins.
Happy to make changes (remove rfc comments, etc) if desired.