Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension permissions #6

Closed
cowbert opened this issue Feb 4, 2021 · 5 comments
Closed

Extension permissions #6

cowbert opened this issue Feb 4, 2021 · 5 comments
Assignees
Labels

Comments

@cowbert
Copy link

cowbert commented Feb 4, 2021

Does this still require permission: "Read and Change all the data on the websites you visit"? It should only require read and change history (since it should basically just suspend the tab based on the history and tab stack order and replace it with the alias to the original uri).

@gioxx gioxx added the let me check I will take some time to verify, investigate and solve the eventual reported problem label Feb 5, 2021
@gioxx gioxx self-assigned this Feb 5, 2021
sherkot added a commit that referenced this issue Feb 7, 2021
@gioxx
Copy link
Owner

gioxx commented Feb 14, 2021

Sorry for the late reply @cowbert.
After @sherkot and I reviewed the code and did more testing together, we realized that access to all websites is only necessary for the screen capture feature offered within the extension.

if you don't use this function and you want to avoid that TMS access to all visited web sites you can certainly set the access property "on click". The extension will continue to work without any problem.

@ThisIsRobin
Copy link

if you don't use this function and you want to avoid that TMS access to all visited web sites you can certainly set the access property "on click". The extension will continue to work without any problem.

Awesome, please make it your highest prio, when thinking about future changes to this tool, that opting out on this with "on click" will always be an option - thanks for the work you are doing!

Cheers!

@gioxx gioxx removed the let me check I will take some time to verify, investigate and solve the eventual reported problem label Feb 15, 2021
@gioxx
Copy link
Owner

gioxx commented Feb 22, 2021

Hello guys!
Yesterday evening, me and @sherkot we have changed some details in the extension that now no longer requires full http/https access permissions during the installation phase, these will be required only when you go to enable screen capture.

If you don't grant the permission, the extension continue to works well without the ability to capture an image of the website before suspension, and the "screen capture" feature remain disabled.

Commit: c235004

I hope this news makes you happy (and in a next occasion we will try to understand if we can also touch up further the permissions section) 😄

@Omar-Elrefaei
Copy link

Nice work. 🔥👍

@alexey-pelykh
Copy link

Awesome 🚀 ! When this version would be released via Chrome app store?

@gioxx gioxx added the fixed label Apr 6, 2021
@gioxx gioxx closed this as completed Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants