Feature - search #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- handle routing inside the main component - receive data from single source of thuth comming from App.js
pass handleShelf down though the BooksContext as oppesed to pass it five layers down via props.
pass handleShelf down though the BooksContext as opposed to pass it five layers down via props. Therefore wirte cleaner code.
pass handleShelf down though the BooksContext as opposed to pass it five layers down via props. Therefore wirte cleaner code.
enable serach book by entering a query
function can be reused for book on mybooks and for book from search results.
handle book with no tumbnails and replace by a default placeholder
by removing the unnecessary dependency, every time book changes the component is updated and book shelves are updated instantly
create useDebounce hook to abstractthe logict for debouncing
create useDebounce hook to abstracthe logic, tehreferofe could be re-used in different components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this branch is created a search functionality:
In there are some important modifications in order to facilitate the data flow between components:
The search feature looks like this: