Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Promote annotations @before and @beforeClass to attributes #175

Merged
merged 5 commits into from
Mar 8, 2024

Conversation

Pixelshaped
Copy link

@Pixelshaped Pixelshaped commented Mar 1, 2024

Fix #174

Opening this pull request to solve deprecations happening with PHPUnit 11, such as Metadata found in doc-comment for method SomeClass::erisSetup(). Metadata in doc-comments is deprecated and will no longer be supported in PHPUnit 12. Update your test code to use attributes instead.

  • Convert @before and @beforeClass annotations to attributes
  • Update the README.md too.
  • Update PHPStan baseline, to solve PHPStan errors
  • Solve own test deprecations (mostly linked to the @DataProvider annotation)
  • Update test matrix to account for PHPUnit11 and PHP8.3

@Pixelshaped
Copy link
Author

@giorgiosironi we seem to be in the clear :)

Please tell me if anything else is needed. I made the PR against 1.x.x as my previous one was also merged against that branch instead of master.

@ilario-pierbattista
Copy link
Collaborator

@Pixelshaped lgtm, this will become 1.0.0-rc2

again, thank you

@ilario-pierbattista ilario-pierbattista merged commit ac9afcc into giorgiosironi:1.x.x Mar 8, 2024
13 checks passed
@ilario-pierbattista ilario-pierbattista added this to the 1.0.0 milestone Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants