fix for PHP 7.4 string index access

[pilif]

This PR fixes two instances of curly bracers used for array and/or string index access. This has been deprecated in PHP 7.4:

see https://wiki.php.net/rfc/deprecate_curly_braces_array_access

[giorgiosironi]

The build has some problems with old PHP versions to solve first. Thanks for the PR, will get it in soon.

[giorgiosironi]

Can you merge master in this to fix the build?

[pilif]

I have rebased on top of your current master

[jdecool]

Some news about this PR ?

[davedevelopment]

@giorgiosironi Hey, we could do with this fix, I'm happy to use a fork for now but if you need any help maintaining eris, I'd be happy to help out. I'm quite comfortable with most testing tools etc.

[antodippo]

Hi guys, I had the same deprecation problem in a Travis build, and I've fixed it with a Composer patch, while waiting for this to be merged and released.
I report here how, maybe it's useful for you:

• require this library, it works also with --dev:
  composer require --dev cweagans/composer-patches
• add this to your composer.json file:

"extra": {
    "patches": {
        "giorgiosironi/eris": {
            "Fix PHP 7.4 deprecation": "https://patch-diff.githubusercontent.com/raw/giorgiosironi/eris/pull/125.patch"
        }
    }
}

• run a composer update on giorgiosironi/eris:
  composer update giorgiosironi/eris

This will refer to this PR, and it will apply it everytime you run a compose update on this library.
You can also take a look at how I did it here: antodippo/exif-reader#5

Hope it helps!

[ilario-pierbattista]

@pilif your last commit broke the CI.
What was intended to fix? Might it be better to fix any other issue in a separate pr?

[pilif]

oh wow - this was a blast from the past. I didn't remember that this PR was still open when I added the commit.

getAnnotations() was removed from PHPUnit 9 and we internally migrated to PHPUnit 9

[ilario-pierbattista]

Fine @pilif how about opening a new issue for adding support to Phpunit 8.x and 9.x?

If you need the change for internal usage, you could also reference a specific commit of your fork. How does it sound to you?

[pilif]

If you need the change for internal usage, you could also reference a specific commit of your fork. How does it sound to you?

of course. I made a honest mistake. I'm sorry. I have reset my branch back to where it was with just the PHP 7.4 fix.

For reference: My initial PR was from September 2019 and my erroneous commit was from December 2020, more than a year later and 6 months after this PR was approved but not merged. By the time I made that commit I had to assume that interesest in merging this has vaned

[ilario-pierbattista]

Thank you @pilif I have no doubt about your good faith.
I think that it's time to move on with php compatibility in order to keep this project alive.

@giorgiosironi I'm sorry for reaching you directly, but this PR has waited for a long time. Could you merge it please?

[giorgiosironi]

Unfortunately I can't dedicate more professional time to this project as I am not active in the PHP community anymore. Happy to hand over commit rights to someone that wants to give a future to this library,

[ilario-pierbattista]

Hi @giorgiosironi I've seen a few of people around here very willing to help.

Personally I have a strong interest in keeping this project alive: it is amazing and I've a lot of tests written with it.
I would be pleased to help maintaining and giving a future to it.

[davedevelopment]

Like I mentioned above, I'm happy to help out if nobody else steps up. I'll be honest though and say it would be in a maintenance capacity rather than further active development, I barely have enough time for work on mockery, so I'd only be here to help fixes like this get merged.

[giorgiosironi]

I have invited you two as Collaborators on this repository. Hopefully, that helps to get the repository into shape, let me know how it goes and if I can tweak anything else.

[ilario-pierbattista]

Thanks @giorgiosironi

Let's start from this pr: thank you @pilif for your contribution!
@davedevelopment from your comment above I assume that you agree to merge this.

[davedevelopment]

@ilario-pierbattista sorry, yes I agree :)