-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fall back to ILU/IC sparselib algorithm with CPU executors #1783
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The OMP tests need to be updated. Otherwise, LGTM
I think we have decided to stay the behavior which throw the error when OMP does not have syncfree algorithm. It is also based on we keep sparselib algorithm although it is not from sparse library in fact. |
The current default does not support OpenMP, so either we change the default, or we fix the breakage. With the CSR strategies, we fall back to a different algorithm if it's unsupported - why the difference here? Both compute the same thing, and have only runtime performance implications. |
I had the same comments on that but it was still the decision we made. |
I actually think it would be better if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO the approach is reasonable. Another alternative which doesn't change the current default, would be to introduce a new enum value, probably default
, which defers to sparselib
on gpu and syncfree
on CPU. But maybe that is a bit overkill.
7d536b1
to
2fb775a
Compare
This issue was found when running the custom multigrid example with OpenMP
2fb775a
to
84fdb1c
Compare
|
There is no reason to make the distinction between algorithms when we only have a single one available. This issue was found when running the custom multigrid example with OpenMP