Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cuda arch 8.9 #1733

Merged
merged 2 commits into from
Nov 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ gko_rename_cache(GINKGO_CUDA_COMPILER_FLAGS CMAKE_CUDA_FLAGS BOOL "Flags used by
# load executor-specific configuration
if(GINKGO_BUILD_CUDA)
include(cmake/cuda.cmake)
if(GINKGO_CUDA_CUSTOM_THRUST_NAMESPACE AND CUDAToolkit_VERSION VERSION_LESS 11.6)
if(CUDAToolkit_VERSION VERSION_LESS 11.6)
message(STATUS "Disable custom thrust namespace for cuda before 11.6 because it has no effect in the thrust shipped by cuda before 11.6")
set(GINKGO_CUDA_CUSTOM_THRUST_NAMESPACE OFF)
else()
Expand Down
12 changes: 7 additions & 5 deletions cmake/Modules/CudaArchitectureSelector.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,10 @@
#
# GPU generation name:
# Has to be one of the strings ``Tesla``, ``Fermi``, ``Kepler``, ``Maxwell``,
# ``Pascal``, ``Volta``, ``Turing``, ``Ampere``. Specifying one of the strings
# will add flags for the generation of CUBIN code for all architectures
# belonging to that GPU generation (except the ones listed in the
# ``UNSUPPORTED`` list).
# ``Pascal``, ``Volta``, ``Turing``, ``Ampere``, ``Ada``, ``Hopper``.
# Specifying one of the strings will add flags for the generation of CUBIN
# code for all architectures belonging to that GPU generation (except the
# ones listed in the ``UNSUPPORTED`` list).
#
# Virtual and physical architecture specification:
# A string of the form ``XX(YY)``, where ``XX`` is the identifier of the
Expand Down Expand Up @@ -240,7 +240,9 @@ function(cas_get_architectures_by_name name output)
set( pascal_version 6)
set( volta_version "7(0|2)")
set( turing_version 75)
set( ampere_version 8)
set( ampere_version "8(0|6|7)")
set( ada_version 89)
set( hopper_version 9)
string(TOLOWER ${name} lower_name)
if(NOT DEFINED ${lower_name}_version)
message(FATAL_ERROR "${name} is not a valid GPU generation name")
Expand Down
1 change: 1 addition & 0 deletions common/cuda_hip/base/executor.hpp.inc
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ inline int convert_sm_ver_to_cores(int major, int minor)
{0x80, 64}, // Ampere Generation (SM 8.0) GA100 class
{0x86, 128}, // Ampere Generation (SM 8.6)
{0x87, 128}, // Ampere Generation (SM 8.7)
{0x89, 128}, // Ada Generation (SM 8.9)
{0x90, 128}, // Hopper Generation (SM 9.0)
{-1, -1}};

Expand Down
Loading