Add rocthrust through cmake #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
reg:build
pratikvn
approved these changes
Aug 16, 2024
yhmtsai
approved these changes
Aug 16, 2024
|
I will wait merging this until spack/spack#45791 is resolved. Maybe there is still something missing. |
|
question: do you create a patch in spack package? or should we release 1.8.1 |
|
There is a patch for the spack package. I think there is no need for an 1.8.1 otherwise. |
|
The spack CI passed, so I consider this PR to be complete. |
MarcelKoch
added
1:ST:ready-to-merge
MarcelKoch
force-pushed
the
fix-rocthrust-cmake
branch
from
1209738 to
1808004
Compare
MarcelKoch
force-pushed
the
fix-rocthrust-cmake
branch
from
1808004 to
fc3931f
Compare
upsj
approved these changes
Aug 19, 2024
MarcelKoch
added a commit
to MarcelKoch/ginkgo
that referenced
this pull request
Dec 2, 2024
This merge uses CMake to find and add rocthrust. This fixes the spack issue reported in spack/spack#44923. Related PR: ginkgo-project#1668
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses CMake to find and add rocthrust. This fixes the spack issue reported in spack/spack#44923.