avoid cyclic ownership with GPU timers #1509
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered by @MarcelKoch,
ProfilerHook::create(_nested)_summary
doesn't work with GPU timers because they keep the executor alive via a cyclic dependency. This breaks up the dependency by storing device ID and stream explicitly.Previously, attaching a ProfilerHook logger with a GPU timer lead to a dependency graph like this:
The new dependency graph removes the cycle