Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gdb pretty-printer #1500

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Update gdb pretty-printer #1500

merged 1 commit into from
Dec 7, 2023

Conversation

upsj
Copy link
Member

@upsj upsj commented Dec 6, 2023

Since the array member names changed, we need to fix the pretty-printer. Also we should avoid running it on pointers to arrays.

@upsj
Update gdb pretty-printer
8ae98d3 
Since the member names changed, we need to fix the pretty-printer
@upsj upsj added the 1:ST:ready-for-review This PR is ready for review label Dec 6, 2023
@upsj upsj requested a review from a team December 6, 2023 23:54
@upsj upsj self-assigned this Dec 6, 2023
@ginkgo-bot ginkgo-bot added the reg:helper-scripts This issue/PR is related to the helper scripts mainly concerned with development of Ginkgo. label Dec 6, 2023
@yhmtsai
Copy link
Member

yhmtsai commented Dec 7, 2023

what does "we should avoid running it on pointers to arrays." mean?
only use it on array<...> not *array<...>?

@upsj
Copy link
Member Author

upsj commented Dec 7, 2023 •
edited
Loading

There are multiple cases where printing a variable can accidentally call this pretty-printer, e.g. if you have a array<IndexType>::value_type return type somewhere or an array<IndexType> * type. We only want to handle the plain array<IndexType> case, which is almost entirely caught by restricting this to structs.

@upsj upsj added 1:ST:no-changelog-entry Skip the wiki check for changelog update 1:ST:skip-full-test 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Dec 7, 2023
@upsj upsj merged commit c67dc10 into develop Dec 7, 2023
@upsj upsj deleted the gdb-pretty-printer-update branch December 7, 2023 14:59
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pratikvn pratikvn pratikvn approved these changes

@MarcelKoch MarcelKoch MarcelKoch approved these changes

@yhmtsai yhmtsai yhmtsai approved these changes

Assignees

@upsj upsj

Labels
1:ST:no-changelog-entry Skip the wiki check for changelog update 1:ST:ready-to-merge This PR is ready to merge. 1:ST:skip-full-test reg:helper-scripts This issue/PR is related to the helper scripts mainly concerned with development of Ginkgo.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@upsj @yhmtsai @pratikvn @MarcelKoch @ginkgo-bot