Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix MSVC __cplusplus by _MSVC_LANG #1496

Merged
merged 1 commit into from
Dec 6, 2023
Merged

fix MSVC __cplusplus by _MSVC_LANG #1496

merged 1 commit into from
Dec 6, 2023

Conversation

yhmtsai
Copy link
Member

@yhmtsai yhmtsai commented Dec 6, 2023

As #1495 mentioned, MSVC does not update __cplusplus as the other compiler by default, which results in the issue mentioned in #1331 (std::uncaught_exception is not a member of std when standard > c++17)
They use _MSVC_LANG for __cplusplus purpose.

@yhmtsai yhmtsai added the 1:ST:ready-for-review This PR is ready for review label Dec 6, 2023
@yhmtsai yhmtsai requested a review from a team December 6, 2023 09:04
@yhmtsai yhmtsai self-assigned this Dec 6, 2023
@ginkgo-bot ginkgo-bot added the mod:core This is related to the core module. label Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (37a63de) 89.30% compared to head (876d8ff) 90.97%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1496      +/-   ##
===========================================
+ Coverage    89.30%   90.97%   +1.67%     
===========================================
  Files          688      688              
  Lines        56328    56113     -215     
===========================================
+ Hits         50304    51050     +746     
+ Misses        6024     5063     -961     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1:ST:ready-to-merge This PR is ready to merge. 1:ST:skip-full-test mod:core This is related to the core module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants