-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Reuse license #1390
WIP: Reuse license #1390
Conversation
this was done using `reuse annotate ... -r .` and - `reuse annotate ... -s c **/*.hpp.inc` - `reuse annotate ... -s c **/*.hpp.in` - `reuse annotate ... -s c **/*.hpp.cu` - `reuse annotate ... -s c **/*.hpp.cuh` (using fish syntax)
|
||
## Third-Party Licenses | ||
|
||
Ginkgo source distribution does not bundle any third-party software. However, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer true since AMD was added
Maybe we can do this in two separate PRs? First replace the license by the SPDX header, then handle automation? |
@upsj This PR handles only the license replacement atm. It only disables our current handling, because that doesn't mix well. The automation (if wanted) should best be handled by pre-commit. But as you noted, we need to adjust the license for files with very little originality. |
I mean shortening only the existing license headers, everything else is a bigger effort |
I will split this PR up into two parts:
I will close this PR in favor of the other two. |
This PR changes how we handle our license declaration. It moves from the current block of license (~30 lines) to 3/4 lines as defined by https://reuse.software/. The new license header will now read as:
Additionally, a license is added to all files in our repository. This includes adding a CC-BY-4.0 license for all of our images. Since the images are binary files, an extra file with a
.license
suffix is created in all cases.The MatrixMarket files are properly attributed, but since these files should not be modified (see the license section in https://sparse.tamu.edu/about) this is handled in the
.reuse/dep5
file. We could also do the same as with the images for those.Some files have a CC0-1.0 license which basically means no copyright. The files are the
*.stderr
and*.stdout
in the benchmark tests, and the filesexamples/*/doc/
.Some files have dual license. These are
FindHWLOC.cmake
(MORSE + our) andexternal-lib-interfacing.cpp
(deal.II + our). I'm currently using anAND
clause to combine the licenses, which means that a user must comply with all licenses simultaneously. The alternative is anOR
clause, which would mean that the user can choose a license.For now I've disabled our pre-commit license check, and instead added a github action for that.
Todo
matrices/test
Benefits of this PR