Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCR solver #1180

Closed
wants to merge 5 commits into from
Closed

GCR solver #1180

wants to merge 5 commits into from

Conversation

upsj
Copy link
Member

@upsj upsj commented Nov 3, 2022

The original PR was closed because the base branch was deleted. #1022

upsj and others added 5 commits December 14, 2021 13:55
@upsj
simplify GMRES kernels
a703e77
Broken first implementation. Not compiling.
afdd880
First working version:
912436e 
+ reference kernels running
+ unified kernels running
+ core and kernel tests implemented
- apparent numerical instability causing kernel tests to fail sometimes
Implemented preconditioning. Cleaned up kernel tests.
8ca9e2e
Added benchmark flag for gcr krylov dim
9ee15e1
@upsj upsj added the 1:ST:WIP This PR is a work in progress. Not ready for review. label Nov 3, 2022
@ginkgo-bot ginkgo-bot added mod:all This touches all Ginkgo modules. reg:benchmarking This is related to benchmarking. reg:build This is related to the build system. reg:testing This is related to testing. type:solver This is related to the solvers labels Nov 3, 2022
@ginkgo-bot
Copy link
Member

Error: The following files need to be formatted:

common/unified/solver/gmres_kernels.cpp
core/solver/gcr.cpp
include/ginkgo/ginkgo.hpp
reference/solver/gcr_kernels.cpp
reference/solver/gmres_kernels.cpp
test/solver/gcr_kernels.cpp
test/solver/gmres_kernels.cpp

You can find a formatting patch under Artifacts here or run format! if you have write access to Ginkgo

@yanjen yanjen mentioned this pull request Dec 12, 2022
Merged
@upsj upsj closed this Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1:ST:WIP This PR is a work in progress. Not ready for review. mod:all This touches all Ginkgo modules. reg:benchmarking This is related to benchmarking. reg:build This is related to the build system. reg:testing This is related to testing. type:solver This is related to the solvers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@upsj @ginkgo-bot